[Pidgin] #5840: Receving transfers through jabber proxy results in corrupt files

[Pidgin]

#5840: Receving transfers through jabber proxy results in corrupt files
---------------------------+------------------------------------------------
  Reporter:  sniperbeamer  |       Owner:  datallah                      
      Type:  defect        |      Status:  assigned                      
  Priority:  minor         |   Milestone:                                
 Component:  XMPP          |     Version:  2.4.2                         
Resolution:                |    Keywords:  file transfer proxy bytestream
   Pending:  1             |  
---------------------------+------------------------------------------------
Changes (by datallah):

  * owner:  nwalp => datallah
  * status:  new => assigned
  * pending:  0 => 1

Comment:

 Hmm... it looks like real problem the server is sending bogus information
 (and libpurple isn't correctly hanging up on it when it does).

 According to [http://www.xmpp.org/extensions/xep-0065.html#proto-establish
 the XEP], it should be sending an ATYP (4th byte) of 03 indicating that it
 is specifying a domain name, the 5th byte should be the length of the
 "address" ('x') and the next x bytes should be the "address" (SHA1 Hash
 of: (SID + Initiator JID + Target JID)).

 I'm going to fix it so that it'll hang up when it receives the invalid
 response from the server.  There is no way that we can know how many bytes
 we should be reading for the address in this case as it violates the
 SOCKS5 specification.

 Do you know what the "server" is in this case? Is it a standalone
 bytestream proxy server or is it another client?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5840#comment:1>
Pidgin <http://pidgin.im>
Pidgin