[Pidgin] #780: Sound event for new email

[Pidgin]

#780: Sound event for new email
----------------------------+-----------------------------------------------
  Reporter:  chrisjames_71  |       Owner:                             
      Type:  patch          |      Status:  new                        
  Priority:  minor          |   Milestone:  Patches Needing Improvement
 Component:  pidgin (gtk)   |     Version:  2.0                        
Resolution:                 |    Keywords:                             
   Pending:  0              |  
----------------------------+-----------------------------------------------
Comment (by bl4):

 Well, I'm not going to block it any longer. Here's the updated patch, I've
 changed everything as rekkanoryo suggested:[[BR]][[BR]]
 - Sound for new email is played similar to other sound events, in a
 callback function which is associated with the libpurple signal for new
 email.[[BR]]
 - Public function namespacing: renamed is_new_mail to
 pidgin_notify_is_new_mail[[BR]]
 - Comments[[BR]][[BR]]
 Other changes:[[BR]][[BR]]
 - Eliminated pidgin_docklet_update_icon_mail function. Instead,
 pidgin_docklet_update_icon recognizes if there's new mail.[[BR]]
 - Moved pidgin_notify_is_new_mail declaration between #ifndef ... #endif
 in the header file, so it can be declared only once.[[BR]]
 [[BR]]
 I haven't had much time for testing but these aren't big modifications and
 everything should work like before. I hope this code matches pidgin code
 better. Please let me know if there are any other issues.[[BR]]
 [[BR]]
 I've just noticed that when I click on the attachment name, a preview of
 the patch is displayed, but it's incomplete. Only modifications for 3
 files are shown, while this patch modifies 6 files.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/780#comment:24>
Pidgin <http://pidgin.im>
Pidgin