[Pidgin] #5541: After killing my internet connection, I can only see myself in xmpp channels
Pidgin
trac at pidgin.im
Tue May 27 20:56:47 EDT 2008
#5541: After killing my internet connection, I can only see myself in xmpp
channels
---------------------+------------------------------------------------------
Reporter: jd49 | Owner: deryni
Type: defect | Status: new
Priority: minor | Milestone:
Component: XMPP | Version: 2.4.1
Resolution: | Keywords: rejoin broken connection muc
Pending: 0 |
---------------------+------------------------------------------------------
Comment (by sadrul):
In the debug log, from what I can see, a !JabberChat is being created from
line 34, and it's destroyed from line 38.
The code that destroys the chat is in jabber/presence.c, lines 610-620:
{{{
/* If we haven't joined the chat yet, we don't care that
someone
* left, or it was us leaving after we closed the chat */
if(!chat->conv) {
if(jid->resource && chat->handle && !strcmp(jid->resource,
chat->handle))
jabber_chat_destroy(chat);
jabber_id_free(jid);
g_free(status);
g_free(room_jid);
g_free(avatar_hash);
return;
}
}}}
It doesn't seem to make a lot of sense to {{{jabber_chat_destroy}}} in
here. Shouldn't we just ignore the message and keep the chat around?
--
Ticket URL: <http://developer.pidgin.im/ticket/5541#comment:8>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list