[Pidgin] #220: Pidgin does not display pictures recieved from Gadu Gadu

[Pidgin]

#220: Pidgin does not display pictures recieved from Gadu Gadu
------------------------+---------------------------------------------------
  Reporter:  MarkS      |       Owner:  bartosz
      Type:  patch      |      Status:  new    
  Priority:  minor      |   Milestone:         
 Component:  Gadu-Gadu  |     Version:  2.0    
Resolution:             |    Keywords:         
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by ono):

 @sabby7890: Please put your patch as single file as described in
 TipsForPatchSubmissions

 Regarding your latest patch:

 1. `msg = charset_convert(msg, "UTF-8", "CP1250");` and some other
 `g_strdup_printf` in `ggp_send_im_richtext` are IMHO memory leaks, since
 you don't free anywhere old `msg` memory buffer.

 2. UTF-8 -> CP1250 should happen at the very end just before sending the
 buffer to `libgadu` function, as all glib functions such as `g_strsplit`
 work in UTF-8 locale, so doing conversion to CP1250 first then working
 with UTF-8 aware functions if pretty bad idea since it may lead to
 unpredictable behavior.

 Anyway I really appreciate your work and looking towards putting it into
 repository once all the memory related things are sorted out.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/220#comment:15>
Pidgin <http://pidgin.im>
Pidgin