[Pidgin] #4449: Use MD5 login for ICQ. Fall back to XOR upon failure.

[Pidgin]

#4449: Use MD5 login for ICQ.  Fall back to XOR upon failure.
--------------------------+-------------------------------------------------
  Reporter:  MarkDoliner  |       Owner:  markdoliner    
      Type:  patch        |      Status:  new            
  Priority:  minor        |   Milestone:  Patches welcome
 Component:  ICQ          |     Version:  2.3.1          
Resolution:               |    Keywords:                 
   Pending:  0            |  
--------------------------+-------------------------------------------------
Comment (by db42):

 Looking at the code, oscar.c , function connection_established_cb :

         if (conn->cookie == NULL)
         {
                 if
 (!aim_snvalid_icq(purple_account_get_username(account)))
                         /*
                          * We don't send this when authenticating an ICQ
 account
                          * because for some reason ICQ is still using the
                          * assy/insecure authentication procedure.
                          */
                         flap_connection_send_version(od, conn);
         }

 Maybe this code was what was causing the MD5 not to work (my code
 basically does the same but in a different function) ?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4449#comment:7>
Pidgin <http://pidgin.im>
Pidgin