[Pidgin] #3796: Pidgin unhappy with XMPP standards-compliant avatars

[Pidgin]

#3796: Pidgin unhappy with XMPP standards-compliant avatars
-------------------------+--------------------------------------------------
 Reporter:  kahlil88     |        Owner:  nwalp 
     Type:  defect       |       Status:  closed
Milestone:               |    Component:  XMPP  
  Version:  2.2.2        |   Resolution:  fixed 
 Keywords:  buddy icons  |  
-------------------------+--------------------------------------------------

Comment(by edam):

 Request to reopen this bug. (This is different to bug 460, which is more
 about pidgin throwing an error instead of automatically resizing buddy
 icons).

 This issue is that, for XMPP, Pidgin seems to convert JPGs and GIFs to
 PNGs unnecessarily. XEP-0153 specifications permit both GIFs, JPGs and
 PNGs, and XEP-0084 has no image restrictions (since v1.1), so the
 conversion is not required.

 By way of an example, consider a 96x96 JPG of about 4KB. This would be
 converted to a 96x96 PNG of about 18KB. The conversion can cause problems
 with servers that only support XEP-0153 (which says: "The image SHOULD use
 less than eight kilobytes (8k) of data; this restriction is to be enforced
 by the publishing client"). Since a conversion from a JPG to a PNG often
 results in an image that exceeds the limit, pidgin ends up sending an
 avatar that is unacceptable to the server. If pidgin had not done the
 conversion, the selected avatar would have been acceptable.

 I believe changing "png" to "png,jpg,gif" in
 libpurple/protocols/jabber/libxmpp.c (line 57) might fix the issue, but I
 have not tested this.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3796#comment:5>
Pidgin <http://pidgin.im>
Pidgin