[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
---------------------------------------+------------------------------------
 Reporter:  minstrel                   |        Owner:  MarkDoliner
     Type:  patch                      |       Status:  new        
Milestone:                             |    Component:  ICQ        
  Version:  2.3.1                      |   Resolution:             
 Keywords:  Custom Icon XStatuses ICQ  |  
---------------------------------------+------------------------------------

Comment(by Gromescu):

 I had two rejects applying this patch
 {{{
 ***************
 *** 5826,5833 ****
                 else
                         ret = g_strdup(_("Offline"));
         }
 -       else
         {
                 message = purple_status_get_attr_string(status,
 "message");
                 if (message != NULL)
                 {
 --- 5922,5940 ----
                 else
                         ret = g_strdup(_("Offline"));
         }
 +       else if (purple_status_is_available(status) && !strcmp(id,
 OSCAR_STATUS_ID_AVAILABLE))
 +       {
 +               /* Available */
 +               message = purple_status_get_attr_string(status,
 "message");
 +               if (message != NULL)
 +               {
 +                       ret = g_strdup(message);
 +                       purple_util_chrreplace(ret, '\n', ' ');
 +               }
 +       }
 +       else if (!purple_status_is_available(status) && !strcmp(id,
 OSCAR_STATUS_ID_AWAY))
         {
 +               /* Away */
                 message = purple_status_get_attr_string(status,
 "message");
                 if (message != NULL)
                 {
 ***************
 *** 5840,5847 ****
                         g_free(tmp2);
                 }
                 else
 -                       ret = g_strdup(purple_status_get_name(status));
         }
         return ret;
   }

 --- 5947,5959 ----
                         g_free(tmp2);
                 }
                 else
 +               {
 +                       ret = g_strdup(_("Away"));
 +               }
         }
 +       else
 +               ret = g_strdup(purple_status_get_name(status));
 +
         return ret;
   }

 }}}
 Edited manually. It seems to be working.

 The problem with away status not appears now. But pidgin still does not
 read na, dnd, occupied statuses from miranda

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:59>
Pidgin <http://pidgin.im>
Pidgin