[Pidgin] #7516: XMPP "headline" messages create new conversation tab in 2.5.2

Pidgin trac at pidgin.im
Tue Nov 11 15:34:08 EST 2008


#7516: XMPP "headline" messages create new conversation tab in 2.5.2
--------------------------+-------------------------------------------------
 Reporter:  jts           |     Owner:  lschiere
     Type:  defect        |    Status:  new     
Component:  unclassified  |   Version:  2.5.2   
 Keywords:                |  
--------------------------+-------------------------------------------------
 Starting in 2.5.2, receiving an XMPP headline message creates a new
 conversation tab. I don't think this is correct behavior - headlines are
 for, e.g., non-interactive announcements. Patch to revert to 2.5.1
 behavior:


 {{{
 --- message_2_5_2.c    2008-11-11 15:26:51.000000000 -0500
 +++ message.c   2008-11-11 15:26:10.107798000 -0500
 @@ -616,7 +616,7 @@
                                                 }

                                                 jabber_id_free(jid);
 -                                       } else {
 +                                       } else if (jm->type !=
 JABBER_MESSAGE_HEADLINE) {
                                                 conv =
 purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY,
                                                                 who,
 account);
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7516>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list