[Pidgin] #78: Logs don't support RTL text correctly.
Pidgin
trac at pidgin.im
Mon Nov 17 15:51:07 EST 2008
#78: Logs don't support RTL text correctly.
----------------------------------------------------------+-----------------
Reporter: shlomil | Owner: rlaager
Type: patch | Status: new
Milestone: Patches Needing Improvement | Component: pidgin (gtk)
Version: 2.0 | Resolution:
Keywords: Hebrew bidi RTL Arabic "bi-directional text" |
----------------------------------------------------------+-----------------
Changes (by rlaager):
* milestone: => Patches Needing Improvement
Comment:
shlomil, if you don't have the time to tackle this, could you address the
following questions and I can probably get this finished up and committed.
I'm sorry it has taken us this long.
There's still a TODO marked in the code that talks about Pango, but it
seems like the approach of the latest patch (pidgin-log-bidi-
support1.diff) is to do the detection without Pango. If that's the case,
can that TODO be removed, or do we still need to do direction detection on
"from" there? Either way, the code that was moved from pidgin to libpurple
still has #ifdef PANGO14, which should probably be removed.
If the *only way* (short of copying in a ton of Pango code or something)
to do this is by adding Pango as a dependency of libpurple, then let's do
that but make it optional (so if you don't have it, RTL text will be
broken or whatever).
--
Ticket URL: <http://developer.pidgin.im/ticket/78#comment:28>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list