[Pidgin] #7282: some unnecessary checking in circbuffer implementation
Pidgin
trac at pidgin.im
Tue Oct 21 23:41:04 EDT 2008
#7282: some unnecessary checking in circbuffer implementation
------------------------+---------------------------------------------------
Reporter: rfan.cn | Owner: datallah
Type: defect | Status: new
Milestone: | Component: libpurple
Version: 2.5.1 | Resolution:
Keywords: circbuffer |
------------------------+---------------------------------------------------
Comment(by datallah):
It looks like you're right; to be sure, I wrote a test that demonstrates
the buffer wrapping in a couple scenarios and we never hit that scenario.
I'm guessing that originally inptr was going to wrap to buffer instead of
sitting at the end, but it really doesn't matter.
--
Ticket URL: <http://developer.pidgin.im/ticket/7282#comment:4>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list