[Pidgin] #7323: Pidgin does not reconnect after Networkmanager sent StateChange

Pidgin trac at pidgin.im
Wed Oct 22 16:11:20 EDT 2008


#7323: Pidgin does not reconnect after Networkmanager sent StateChange
--------------------------------------+-------------------------------------
 Reporter:  aneiser                   |        Owner:           
     Type:  patch                     |       Status:  new      
Milestone:                            |    Component:  libpurple
  Version:  2.5.2                     |   Resolution:           
 Keywords:  networkmanager reconnect  |  
--------------------------------------+-------------------------------------

Comment(by nosnilmot):

 That patch looks wrong, there is no guarantee that we are actually
 connected to the NM dbus service at that point, and the
 nm_dbus_name_owner_changed_cb() callback is supposed to handle this
 already.

 A possible alternative would be to change
 {{{
 if (prev != NM_STATE_CONNECTED)
 }}}
 to
 {{{
 if (prev != NM_STATE_CONNECTED && prev != NM_STATE_UNKNOWN)
 }}}
 in nm_update_state(), although I don't know if that will have negative
 side effects.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7323#comment:4>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list