[Pidgin] #6589: Add UDP connections to purple_proxy_connect
Pidgin
trac at pidgin.im
Mon Sep 1 11:43:42 EDT 2008
#6589: Add UDP connections to purple_proxy_connect
-----------------------+----------------------------------------------------
Reporter: ccpaging | Owner:
Type: patch | Status: new
Milestone: | Component: libpurple
Version: 2.4.3 | Resolution:
Keywords: UDP proxy |
-----------------------+----------------------------------------------------
Comment(by elb):
If I understand this patch, it is not reasonable. There should not be a
user-visible setting of "UDP" as a proxy type for all accounts -- for
everything but QQ (and ICQ protocols we do not support, and may not even
exist any more), that is meaningless. The user should not be presented
with meaningless options which are guaranteed to fail.
The choice between TCP and UDP doesn't map to a "proxy type" in most
cases; generally, protocols are different between TCP and UDP even for
services which support both. (E.g., UDP requires application-level
retransmissions, etc.) If parts of the purple_proxy framework can be
broken out to better support UDP, great, do that -- but the connection
should probably be via purple_proxy_connect_udp or similar, rather than
trying to shoehorn UDP into the existing proxy framework. Protocols
ultimately have to make the decision of whether to use UDP or TCP. There
should be, in this case, a checkbox somewhere in QQ account settings for
"Use UDP"; when it is checked, QQ should use UDP rather than TCP, along
with whatever attendant protocol changes that incurs (if any). It sounds
like this is what is happening now, you just want to push some of that
code into libpurple. That's fine, but do it in parallel.
Hope that made sense.
--
Ticket URL: <http://developer.pidgin.im/ticket/6589#comment:6>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list