[Pidgin] #1178: Protocol autoswitching should print out a notification in the conversation window

[Pidgin]

#1178: Protocol autoswitching should print out a notification in the conversation
window
-----------------------------------------+----------------------------------
 Reporter:  cdmarcus                     |        Owner:              
     Type:  enhancement                  |       Status:  new         
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.0                          |   Resolution:              
 Keywords:                               |  
-----------------------------------------+----------------------------------

Comment(by rlaager):

 1. The bottom three hunks of the patch are useless changes. You should
 undo those so they don't show up in the diff.

 2. You're using different indentation. Look at your patch here in the Trac
 viewer and it should be obvious. Use tabs, not spaces.

 3. The check to see if the protocol changed is not necessary. If you're
 reaching this code, the account must have changed. (See the "if (old_conv
 == conv) return;" code on lines 2231-2232.)

 4. Related to point 3, I see no reason to special case changing protocols
 when you can just print a message on account change. All you really need
 is:
 {{{
 message = g_strdup_printf("This conversation has been switched to %s.",
                           purple_account_get_username(conv->account));
 purple_conversation_write(...);
 g_free(message);
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1178#comment:27>
Pidgin <http://pidgin.im>
Pidgin