[Pidgin] #7081: purple_status_set_active_with_attrs_list() always does a status update if any attributes are unspecified

Pidgin trac at pidgin.im
Sun Sep 14 15:51:14 EDT 2008


#7081: purple_status_set_active_with_attrs_list() always does a status update if
any attributes are unspecified
----------------------+-----------------------------------------------------
Reporter:  JonTurney  |        Type:  patch    
  Status:  new        |   Component:  libpurple
 Version:  2.5.1      |    Keywords:           
----------------------+-----------------------------------------------------
 purple_status_set_active_with_attrs_list() always sets the changed flag,
 causing the status to be updated, if the status has any unspecified
 attributes (which are implicitly set to their default values), which may
 cause the protocol to do all the work of sending the status again, even
 though it hasn't actually changed.

 Attached patch shows how we might avoid this unneeded work by checking if
 the value of these attributes is actually changing.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7081>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list