[Pidgin] #7047: memory leak and logic error in proxy.c in pidgin 2.5.1

[Pidgin]

#7047: memory leak and logic error in proxy.c in pidgin 2.5.1
--------------------------+-------------------------------------------------
 Reporter:  rfan.cn       |        Owner:  nosnilmot
     Type:  patch         |       Status:  closed   
Milestone:  2.5.2         |    Component:  libpurple
  Version:  2.5.1         |   Resolution:  fixed    
 Keywords:  proxy detect  |  
--------------------------+-------------------------------------------------

Comment(by nosnilmot):

 Replying to [ticket:7047 rfan.cn]:
 > '''(2)Regards logic error:'''
 >
 > line: 257
 >
 {{{
  if (!g_spawn_command_line_sync("gconftool-2 -g
 /system/http_proxy/use_same_proxy", &tmp, &err, NULL, NULL))
      return purple_global_proxy_get_info();
 }}}
 >
 > here no such "/system/http_proxy/use_same_proxy" entry in gnome global
 configuration, from my understanding, developer just want to check wether
 there set  "/system/http_proxy/use_http_proxy".
 > * if no, if socks5 proxy host also be set, then can be decided socks5
 proxy want to be used.
 > * if yes, then it can be decided the http proxy want to be used.

 This is not a logic error, this is working as intended. Newer GNOME
 includes the /system/http_proxy/use_same_proxy key. On older GNOME, the
 code will still work as I intended it to (prefer socks proxy if specified,
 otherwise use http proxy).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7047#comment:13>
Pidgin <http://pidgin.im>
Pidgin