[Pidgin] #6976: Encoding problem in Pidgin with GTK+ 2.12.8 rev a

[Pidgin]

#6976: Encoding problem in Pidgin with GTK+ 2.12.8 rev a
--------------------+-------------------------------------------------------
 Reporter:  xtonda  |        Owner:  MarkDoliner
     Type:  defect  |       Status:  new        
Milestone:          |    Component:  AIM        
  Version:  2.5.1   |   Resolution:             
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by datallah):

 Replying to [comment:8 xtonda]:
 > Trillian sends message probably in windows-1250 encoding (since this is
 default on windows in my region), so do nothing with the message and just
 display it should work when both users are on windows and this is probably
 what happens in GTK+ to 2.12.1 rev b, but GTK+ 2.12.8 rev a tries to
 perform some unappropriate conversion.

 Everything in libpurple internally uses UTF-8, so we have to somehow
 convert from whatever the message comes in as to UTF-8 (this has always
 been the case).  For protocols like ICQ and IRC where there is no encoding
 information provided, we have to use whatever the account is configured to
 use (we also use the system locale fallback for ICQ).

 For AIM, there is a specific encoding associated with each message (in
 this case, ASCII) - so we convert the incoming message using that.  Given
 that ASCII is a subset of UTF-8 - arguably we don't need to do a
 conversion at all here (perhaps that would be a workaround).  Presumably
 the difference between the older iconv behavior and the new iconv behavior
 is that previously it didn't validate the inbound text in the same way it
 is now.

 So, as far as I can tell, the bug is really in the other client sending
 something as ASCII that is not.  That it happened to work previously is
 something of a coincidence/bug.  When there is an encoding specified by
 the protocol, we must use that.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6976#comment:10>
Pidgin <http://pidgin.im>
Pidgin