[Pidgin] #8830: Pidgin 2.5.5 crash with jabber

[Pidgin]

#8830: Pidgin 2.5.5 crash with jabber
------------------------------------+---------------------------------------
 Reporter:  Nico                    |        Owner:  deryni
     Type:  patch                   |       Status:  new   
Milestone:  Patches Needing Review  |    Component:  XMPP  
  Version:  2.5.5                   |   Resolution:        
 Keywords:  jabber                  |  
------------------------------------+---------------------------------------
Changes (by deryni):

  * owner:  lschiere => deryni
  * type:  defect => patch
  * milestone:  => Patches Needing Review


Comment:

 Assuming we attempt to parse a manual closing of the stream do we need the
 second call to xmlParseChunk for NULL? Does that not look like an error
 given that we have told libxml2 that the previous </stream> chunk was the
 last chunk?

 That aside, I don't think doing that there is likely correct anyway. I
 think it more likely to want to be done in jabber_stream_init
 {{{
 if (js->reinit) {
     xmlParseChunk(js->context, "</stream:stream">, 0, 0);
 }
 }}}
 or (more likely) with a function in parser.c which does that.

 A side question is: Why would we want to install a structured error
 handler in the xmlnode.c parser? (Especially one that copies the XMPP-
 specific vcard-temp warning supression. =) )

 This crash appears to be different than the one I had seen a while back
 (#8136) which is curious.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8830#comment:8>
Pidgin <http://pidgin.im>
Pidgin