[Pidgin] #8738: XMPP: Only send XHTML if there is markup

Pidgin trac at pidgin.im
Mon Apr 13 15:39:00 EDT 2009


#8738: XMPP: Only send XHTML if there is markup
-----------------------------------------+----------------------------------
 Reporter:  darkrain42                   |        Owner:  malu
     Type:  patch                        |       Status:  new 
Milestone:  Patches Needing Improvement  |    Component:  XMPP
  Version:  2.5.5                        |   Resolution:      
 Keywords:  xhtml                        |  
-----------------------------------------+----------------------------------
Changes (by darkrain42):

  * owner:  deryni => malu
  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 This breaks sending custom emoticons.

 malu, it seems like the easiest solution (at least from my lazy
 perspective) would be to move the BoB code from `jabber_message_send` to
 `jabber_message_send_im` (and later, if we start supporting custom
 emoticons in MUCs, `jabber_message_send_chat`) and add another check on
 {{{
 if ((!jbr || jbr->capabilities & JABBER_CAP_XHTML) &&
     !jabber_xhtml_plain_equal(xhtml, jm->body))
 }}}
 for `message_has_custom_smileys()`.

 Do you see any problems with that/Does that make sense?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8738#comment:4>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list