[Pidgin] #8694: Support NetworkManager 0.7 multiple devices

[Pidgin]

#8694: Support NetworkManager 0.7 multiple devices
------------------------------------+---------------------------------------
 Reporter:  pedric                  |        Owner:           
     Type:  patch                   |       Status:  new      
Milestone:  Patches Needing Review  |    Component:  libpurple
  Version:  2.5.5                   |   Resolution:           
 Keywords:  NetworkManager          |  
------------------------------------+---------------------------------------

Comment(by QuLogic):

 This code needs some cleanup:
  * No // comments, please.
  * I'm no D-Bus expert, but why do we need the marshallers file when we
 never had it before?
  * You should use `PKG_CHECK_EXISTS` to look for NM >= 0.7;
 `PKG_CHECK_MODULES` will print an error for NM < 0.7 instead.
  * You shouldn't `g_strdup` the input to `g_hash_table_lookup`.
  * There are some incorrect casts like to a `gpointer *` where a
 `gpointer` is required.
  * Why do you need a new proxy for each device?
  * You `g_strdup` key for the hash table, but didn't specify a destroy
 function for it.
  * `nm_device_proxy_tmp` is leaked when you malloc it and then immediately
 replace the value.
  * It appears that nothing is ever removed from the hash table (assuming
 you have something like a USB-Ethernet dongle that you unplugged).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8694#comment:4>
Pidgin <http://pidgin.im>
Pidgin