[Pidgin] #8694: Support NetworkManager 0.7 multiple devices
Pidgin
trac at pidgin.im
Tue Apr 21 07:13:46 EDT 2009
#8694: Support NetworkManager 0.7 multiple devices
-----------------------------------------+----------------------------------
Reporter: pedric | Owner:
Type: patch | Status: new
Milestone: Patches Needing Improvement | Component: libpurple
Version: 2.5.5 | Resolution:
Keywords: NetworkManager |
-----------------------------------------+----------------------------------
Comment(by pedric):
Replying to [comment:4 QuLogic]:
> This code needs some cleanup:
> * No // comments, please.
okay.
> * I'm no D-Bus expert, but why do we need the marshallers file when we
never had it before?
NetworkManager does not (yet) provide the marshallers required for its
signals. Using dbus directly, this is currently the only, however ugly way
to get the callbacks to trigger.
> * You should use `PKG_CHECK_EXISTS` to look for NM >= 0.7;
`PKG_CHECK_MODULES` will print an error for NM < 0.7 instead.
I'll have a look at this.
> * Why do you need a new proxy for each device?
The dbus path of each device differs, and you cannot set a proxy to a dbus
path using wildcards.
> * It appears that nothing is ever removed from the hash table (assuming
you have something like a USB-Ethernet dongle that you unplugged).
That was left out on purpose, and is something that will be added as the
patch matures.
I plan to rewrite this patch using libnm_glib (that was rewritten with NM
0.7 and hopefully is more stable than previous versions).
--
Ticket URL: <http://developer.pidgin.im/ticket/8694#comment:6>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list