[Pidgin] #9013: Change hardcoded CLOSE_CONV_TIMEOUT_SECS to user selected value

Pidgin trac at pidgin.im
Wed Apr 22 15:16:38 EDT 2009


#9013: Change hardcoded CLOSE_CONV_TIMEOUT_SECS to user selected value
------------------------------------+---------------------------------------
 Reporter:  dlou99                  |        Owner:              
     Type:  patch                   |       Status:  new         
Milestone:  Patches Needing Review  |    Component:  pidgin (gtk)
  Version:  2.5.5                   |   Resolution:              
 Keywords:                          |  
------------------------------------+---------------------------------------

Comment(by dlou99):

 Replying to [comment:2 deryni]:
 > What is the usage case for adding this preference? Why would people want
 or need to change this?

 The line item in the changelog says "Closing an IM no longer immediately
 closes your conversation. It will now remain active for a short time so
 that if the conversation resumes, the history will be retained. A
 preference has been added to toggle this behavior."  That's pretty much
 the use case except that this patch allows the user to define what a
 'short time' really means.

 Comments in the code say "I am going to consider 10 minutes as a
 'reasonable timeout' here."  I disagree that 10 minutes is 'reasonable'.
 I'm sure others are going to disagree with me if I defined 'reasonable' as
 something else.  So why not make everybody happy and let them come up with
 their own definition of 'reasonable'?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9013#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list