[Pidgin] #9843: oscar prpl makes unnecessary calls to get user info for each oncoming buddy that is away
Pidgin
trac at pidgin.im
Wed Aug 5 00:44:28 EDT 2009
#9843: oscar prpl makes unnecessary calls to get user info for each oncoming buddy
that is away
--------------------------+-------------------------------------------------
Reporter: tmm1 | Owner: rekkanoryo
Type: defect | Status: new
Component: unclassified | Version: 2.5.8
Keywords: |
--------------------------+-------------------------------------------------
attached patch fixes strange behavior reported in #4052 where some away
messages are in html and others are not, and randomly switch back and
forth.
basically the call to aim_locate_autofetch_away_message is unnecessary,
because buddychange snacs already contain each user's away message and
aim_info_extract is able to pull it out. the extra calls to
locate/user_info can cause rate limiting if you have a lot of buddies that
are away.
this also means that the locate/user_info snac is only necessary for
serv_get_info, and the data passed to purple_got_infoblock should not
update the buddylist, because it contains an html version of the away
message. this html version should only be used in the user info window's
html view.
--
Ticket URL: <http://developer.pidgin.im/ticket/9843>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list