[Pidgin] #9841: non seekable stream and file transfer.

Pidgin trac at pidgin.im
Thu Aug 6 23:23:44 EDT 2009


#9841: non seekable stream and file transfer.
---------------------+------------------------------------------------------
 Reporter:  kenshin  |        Owner:           
     Type:  patch    |       Status:  new      
Milestone:  3.0.0    |    Component:  libpurple
  Version:           |   Resolution:           
 Keywords:  ft       |  
---------------------+------------------------------------------------------

Comment(by QuLogic):

 1. The whitespace in this patch is completely wrong and inconsistent.
 Please read CodingStandards.
  1. `gpointer` is a pointer already. `gpointer *` is redundant.
  1. You don't really need to prefix static functions with underscore.
  1. The hash table should be defined at the top of the file, not somewhere
 in the middle of a function. That should fix the weirdness in
 `xfer_was_cancelled_cb`. It should be created in `_init` and destroyed in
 `_uninit`.
  1. The category specified to `purple_debug_*` is inconsistent with the
 rest of the file. There shouldn't be tabs in the output.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9841#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list