[Pidgin] #9844: Abstract Filetransfer
Pidgin
trac at pidgin.im
Fri Aug 7 01:48:53 EDT 2009
#9844: Abstract Filetransfer
------------------------------------+---------------------------------------
Reporter: hanzz | Owner:
Type: patch | Status: new
Milestone: Patches Needing Review | Component: libpurple
Version: 2.5.8 | Resolution:
Keywords: |
------------------------------------+---------------------------------------
Comment(by hanzz):
Replying to [comment:5 darkrain42]:
> Hmmm, waiting_for_data doesn't seem to be read anywhere, it's just
written to. Is the idea that the UI will examine it (and know that it
needs to call `purple_xfer_ui_got_data`)? If so, is it actually necessary
to add something to the !PurpleXfer? Couldn't the UI just track that
itself? (I'm mostly looking to avoid ABI-breaking changes, otherwise I'd
have no problem with the flag being in !PurpleXfer).
You are right, UI can track it, so I can remove this variable.
>
> On a related note, how do you deal with the checksum function in OSCAR
that wants to read the file from the local disk? (Or is that only used for
AIM? I looked briefly but I can't tell).
Hm, I've just checked the log and it seems it just works without checksum.
Do we want some function to set/read checksum of file? I think not all
XMPP clients are sending checksums, but it should be useful for other UIs.
--
Ticket URL: <http://developer.pidgin.im/ticket/9844#comment:8>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list