[Pidgin] #6987: Padding around chat window is unnecessary

Pidgin trac at pidgin.im
Mon Aug 17 17:31:07 EDT 2009


#6987: Padding around chat window is unnecessary
------------------------------------+---------------------------------------
 Reporter:  moreati                 |        Owner:  deryni      
     Type:  patch                   |       Status:  new         
Milestone:  Patches Needing Review  |    Component:  pidgin (gtk)
  Version:  2.5.1                   |   Resolution:              
 Keywords:                          |  
------------------------------------+---------------------------------------

Comment(by deryni):

 That after screenshot has horrible border clipping and other issues.

 The infopane text looks unevenly placed between the top of the window and
 the history area, the border between the history area and the frame
 background is no longer clean but rather a stark color change at an
 (apparently) arbitrary point, the scrollbar arrows try but don't quite
 line up flush with the external border of the history area leaving a
 'smudge' line, and possibly worst of all the input area swallows
 essentially all border indication and looks like it overflowed the space
 it was supposed to be given.

 I'm not sure how many of those changes are attributable to the patch
 versus your other theme changes but on the whole I think the after shot
 looks immensely worse than the before shot and does so for no real gain
 that I can see. The only benefit I can see is that under certain specific
 circumstances it becomes easier to target the scrollbar with the mouse.
 Those circumstances being when the window sits flush with the right edge
 of the desktop, and the GTK+ tab, and window manager window borders have
 zero size (a scenario I doubt ever really happens). In all other cases
 moving the scrollbar to the side of the window is of no real help. Oh, let
 us not forget that the scroll wheel works in the entire history area as a
 way to scroll so targetting the scrollbar is not even really all that
 necessary (not to mention that if you click in the history area the arrow
 keys and page up/page down keys navigate the history area as well).

 Do you see some other benefit(s) to this change? Even with an incredibly
 tiny font size of six pixels removing this padding would only buy you two
 characters per line, that is an awfully small return for this change.

 I will build a copy of pidgin with the padding change and see what the
 resulting window looks like, but I'm not convinced it will be better
 enough in any real way to warrant the change.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6987#comment:6>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list