[Pidgin] #9968: purple_markup_html_to_xhtml adds <html>

Wed Aug 19 18:50:07 EDT 2009

#9968: purple_markup_html_to_xhtml adds <html>
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  MarkDoliner
     Type:  defect      |       Status:  new        
Milestone:  2.6.2       |    Component:  libpurple  
  Version:  2.6.1       |   Resolution:             
 Keywords:              |  
------------------------+---------------------------------------------------
Changes (by darkrain42):

  * milestone:  => 2.6.2

Old description:

> From my conversation logs, I see this (note the "<html>").
>
> {{{
> <font color="#A82F2F"><font size="2">(2009-08-19 15:21:32)</font>
> <b>Alanna:</b></font> <span style='background: #E68CBD;'><span
> style='color: #000000;'><html><body ichatballooncolor="#E68CBD"
> ichattextcolor="#000000"><span style='font-family: Helvetica; color:
> #000000;'>blah</span></body></span></span><br/>
> }}}
>
> Rendered by the history plugin as (2009-08-19 15:21:32) Alanna:
> <html>blah
>
> If I revert this change in util.c:
> {{{
> ============================================================
> --- libpurple/util.c    c4d036a2d4968d1873234c4e0f034c4ee84b1055
> +++ libpurple/util.c    d46fbed17aa183fbfcca507ff111fb48a5eacaa4
> @@ -1569,9 +1569,8 @@ purple_markup_html_to_xhtml(const char *
>                                 ALLOW_TAG("h5");
>                                 ALLOW_TAG("h6");
>                                 /* we only allow html to start the
> message */
> -                               if(c == html) {
> +                               if(c == html)
>                                         ALLOW_TAG("html");
> -                               }
>                                 ALLOW_TAG_ALT("i", "em");
>                                 ALLOW_TAG_ALT("italic", "em");
>                                 ALLOW_TAG("li");
> }}}
>
> I get this in the logs (<html> shouldn't be there at all, but at least
> this is properly escaped):
> {{{
> <font color="#A82F2F"><font size="2">(2009-08-19 15:34:58)</font>
> <b>Alanna:</b></font> <span style='background: #E68CBD;'><span
> style='color: #000000;'><html><body ichatballooncolor="#E68CBD"
> ichattextcolor="#000000"><span style='font-family: Helvetica; color:
> #000000;'>mrow!</span></body></html></span></span><br/>
> }}}

New description:

 From my conversation logs, I see this (note the "<html>").

 {{{
 <font color="#A82F2F">
         <font size="2">(2009-08-19 15:21:32)</font>
         <b>Person:</b>
 </font>
 <span style='background: #E68CBD;'>
         <span style='color: #000000;'>
                 <html>
                 <body ichatballooncolor="#E68CBD"
 ichattextcolor="#000000"><span style='font-family: Helvetica; color:
 #000000;'>
                         blah
                 </span></body>
         </span>
 </span>
 <br/>
 }}}

 Rendered by the history plugin as (2009-08-19 15:21:32) Alanna: <html>blah

 If I apply this change in util.c:
 {{{
 ============================================================
 --- libpurple/util.c    c4d036a2d4968d1873234c4e0f034c4ee84b1055
 +++ libpurple/util.c    d46fbed17aa183fbfcca507ff111fb48a5eacaa4
 @@ -1569,9 +1569,8 @@ purple_markup_html_to_xhtml(const char *
                                 ALLOW_TAG("h5");
                                 ALLOW_TAG("h6");
                                 /* we only allow html to start the message
 */
 -                               if(c == html) {
 +                               if(c == html)
                                         ALLOW_TAG("html");
 -                               }
                                 ALLOW_TAG_ALT("i", "em");
                                 ALLOW_TAG_ALT("italic", "em");
                                 ALLOW_TAG("li");
 }}}

 I get this in the logs (<html> shouldn't be there at all, but at least
 this is properly escaped):
 {{{
 <font color="#A82F2F">
         <font size="2">(2009-08-19 15:34:58)</font>
         <b>Person:</b>
 </font>
 <span style='background: #E68CBD;'>
         <span style='color: #000000;'>
                 <html>
                         <body ichatballooncolor="#E68CBD"
 ichattextcolor="#000000">
                                 <span style='font-family: Helvetica;
 color: #000000;'>
                                         mrow!
                                 </span>
                         </body>
                 </html>
         </span>
 </span>
 <br/>
 }}}

--

Comment:

 formatting a little...

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9968#comment:1>
Pidgin <http://pidgin.im>
Pidgin

[Pidgin] #9968: purple_markup_html_to_xhtml adds &lt;html>

[Pidgin] #9968: purple_markup_html_to_xhtml adds <html>