[Pidgin] #9968: purple_markup_html_to_xhtml adds <html>

Wed Aug 19 20:12:58 EDT 2009

#9968: purple_markup_html_to_xhtml adds <html>
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  MarkDoliner
     Type:  defect      |       Status:  new        
Milestone:  2.6.2       |    Component:  libpurple  
  Version:  2.6.1       |   Resolution:             
 Keywords:              |  
------------------------+---------------------------------------------------

Comment(by darkrain42):

 Yeah, sorry, that is pretty unclear (I'm on a caffeine rush from the
 caffeine I didn't drink...or something).

 So an incoming message looks like this:
 {{{
 Message: <html><body ichatballooncolor="#E68CBD"
 ichattextcolor="#000000"><font face="Helvetica" ABSZ=12 color="#000000">i
 should eat :/</font></body></html>
 }}}

 By the time it gets to `log.c:html_logger_write` (which calls
 purple_markup_html_to_xhtml, as a note), the message looks like this (the
 escaping is because I pulled this from gdb):
 {{{
     message=0x38b2150 "<font back=\"#E68CBD\"><font
 color=\"#000000\"><html><body ichatballooncolor=\"#E68CBD\"
 ichattextcolor=\"#000000\"><font face=\"Helvetica\" ABSZ=12
 color=\"#000000\">\\o/</font></body></html></font></font>")
 }}}

 Since <html/> isn't the outermost element, purple_markup_html_to_xhtml
 gets upset and doesn't allow it as a tag (and apparently escapes the '<'?
 I didn't know it did that...).

 The reason this worked without the braces is that the second part of
 ALLOW_TAG_ALT (the reason the braces were added) matched "<html>" (the
 first part matches "<html ", I think).

 I ''think'' the proper solution is to strip <html/> in the OSCAR prpl, but
 I'm not sure...

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9968#comment:4>
Pidgin <http://pidgin.im>
Pidgin

[Pidgin] #9968: purple_markup_html_to_xhtml adds &lt;html>

[Pidgin] #9968: purple_markup_html_to_xhtml adds <html>