[Pidgin] #10003: Segmentation fault with empty photo in vCard

[Pidgin]

#10003: Segmentation fault with empty photo in vCard
---------------------+------------------------------------------------------
Reporter:  matthewc  |        Type:  defect   
  Status:  new       |   Component:  libpurple
 Version:  2.6.1     |    Keywords:           
---------------------+------------------------------------------------------
 My Jabber server sends a vCard that looks like this:

 (15:25:11) jabber: Recv (ssl)(559): <iq from='mattc at xxxxxx.com'
 to='mattc at xxxxxx.com/Work' id='purplee04b3573' type='result'><vCard xmlns
 ='vcard-temp'><NICKNAME>Doc</NICKNAME><FN>Matthew
 Chapman</FN><TITLE></TITLE><URL></URL><DESC></DESC><TEL><VOICE/><WORK/><NUMBER></NUMBER></TEL><EMAIL><INTERNET/><PREF/><USERID>matthew.chapman at xxxxxx.com</USERID></EMAIL><BDAY></BDAY><ROLE></ROLE><PHOTO><BINVAL></BINVAL></PHOTO><N><MIDDLE></MIDDLE></N><ORG><ORGNAME></ORGNAME><ORGUNIT></ORGUNIT></ORG><ADR><CTRY></CTRY><LOCALITY></LOCALITY><STREET></STREET><REGION></REGION><PCODE></PCODE></ADR></vCard></iq>

 The empty BINVAL inside PHOTO causes Pidgin to segfault (backtrace
 attached).

 It can be fixed by checking the return value of xmlnode_get_data at
 buddy.c:910 as in the attached patch.

 Thanks,
 Matt

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10003>
Pidgin <http://pidgin.im>
Pidgin