[Pidgin] #10891: gevolution plugin adds buddies to random account

[Pidgin]

#10891: gevolution plugin adds buddies to random account
-----------------------------------------+----------------------------------
 Reporter:  cedel                        |        Owner:         
     Type:  patch                        |       Status:  new    
Milestone:  Patches Needing Improvement  |    Component:  plugins
  Version:  2.6.3                        |   Resolution:         
 Keywords:  gevolution Evolution         |  
-----------------------------------------+----------------------------------

Comment(by cedel):

 Replying to [comment:2 darkrain42]:
 > It ''looks'' like there's a lot of needless re-indentation that makes it
 difficult (for me...I'm lazy...) to review the patch.
 >
 > Take a look at line 451 of
 [http://developer.pidgin.im/attachment/ticket/10891/matching_account_entry.diff
 add_buddy_dialog.c in the patch].
 >
 > If i missed a reason for the indentation, my apologies, but I didn't see
 one.

 Re-indentation? I'm sorry, I don't exactly understand what you mean (after
 all, I'm not native english speaker)...
 The code is indented by one Tab from the bracket, I tried to break lines
 longer then some  80-100 characters and in some cases (along the lines of
 the present plugin code) put separate parameters on individual lines (like
 in treeview etc.). Maybe that's what's causing the problems? To be true,
 the indentation and word wrap looks different in Eclipse, in Bluefish and
 on the page (in Trac).

 So, to improve the patch, you want me to remove the indentation and manual
 line wrap?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10891#comment:3>
Pidgin <http://pidgin.im>
Pidgin