[Pidgin] #10933: Our protocol is not supported by the server when using pidgin to connect to MSN

[Pidgin]

#10933: Our protocol is not supported by the server when using pidgin to connect to
MSN
---------------------------------------------------------+------------------
 Reporter:  kamelryttarn                                 |        Owner:  khc
     Type:  defect                                       |       Status:  new
Milestone:                                               |    Component:  MSN
  Version:  2.4.1                                        |   Resolution:     
 Keywords:  Our protocol is not supported by the server  |  
---------------------------------------------------------+------------------

Comment(by maulkin):

 Hi all,

 A quick summary of what I've found in libpurple. Please not that this
 seems to
 be present in 2.6.4 as well as 2.4.3lenny5.

 The MSN protocol's first step is to verify capabilities of the server.
 So, the client sends to the server it's "I can handle foo" message:
  VER 1 MSNP9 MSNP8 CVR0
 It seems that the servers are now replying:
  VER 1 MSNP8

 They certainly don't take MSNP9 anymore, as sending:
  VER 1 MSNP9
 returns:
  VER 1 0

 This should still be fine, as the server means "Oh, ok, I'll take MSNP8
 please, as you said you'd support it and it's better than CVR".

 Unfortunately, it looks like libpurple/protocols/msn/notification.c, line
 309
 in ver_cmd() simply checks the received string for session->protocol_ver.
 This
 isn't found, so it bails out.

 The correct fix would probably be to store some sort of structure of
 supported
 versions and check against that.

 Cheers,
 Neil

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10933#comment:1>
Pidgin <http://pidgin.im>
Pidgin