[Pidgin] #1643: MSN File transfer doesn't close handle when file sending completes.

Pidgin trac at pidgin.im
Mon Dec 14 02:25:58 EST 2009


#1643: MSN File transfer doesn't close handle when file sending completes.
---------------------+------------------------------------------------------
 Reporter:  Dedalus  |        Owner:  khc   
     Type:  defect   |       Status:  closed
Milestone:  2.6.5    |    Component:  MSN   
  Version:  2.0.1    |   Resolution:  fixed 
 Keywords:  ft       |  
---------------------+------------------------------------------------------
Changes (by qulogic at pidgin.im):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 2.6.5


Comment:

 (In [780ee14f6ced21de7257b3149c186223ab446d57]):[[BR]]
 Don't call purple_xfer_start in msn_xfer_init. purple_xfer_start is called
 later after the other side accepts, and this second call clobbers the file
 handle. This file handle is leaked resulting in Pidgin appearing to lock
 the file stopping Windows from being able to delete it.

 The changes from darkrain42's branch actually fixed the real file handle
 leak except for the addition of this one line.

 Fixes #1643.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1643#comment:14>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list