[Pidgin] #8352: fix for first click on submenus problem

Pidgin trac at pidgin.im
Thu Feb 5 08:13:09 EST 2009


#8352: fix for first click on submenus problem
------------------------+---------------------------------------------------
     Reporter:  oopepe  |        Type:  patch       
       Status:  new     |   Component:  pidgin (gtk)
      Version:  2.5.4   |    Keywords:              
Launchpad_bug:          |  
------------------------+---------------------------------------------------
 The Problem: [[BR]]

 When i start Pidgin and open a menu and then click on a submenu before it
 automatically opens the submenu wouldnt open at all.
 I had this problem on vista 64bit and openSuse 11 32bit.
 [[BR]]
 The following submenus have this issue:[[BR]]
 - Plugin menus under the Tools menu[[BR]]
 - 'Activate Account' under the Account menu[[BR]]
 - all account submenus under the Account menu[[BR]]
 - all Plugin menus on the tray menu[[BR]]

 What i did about it:[[BR]]

 When a menu or a submenu gets created
 {{{
 gtk_widget_show(menuitem);
 }}}
 is called on it. That was the Problem.
 When i removed all this calls and placed a
 {{{
 gtk_widget_show_all(parentmenu);
 }}}
 later when all menu creation was done the clicking problem disappeared.
 For the tray menu a
 {{{
 gtk_widget_show_all(parentmenu);
 }}}
 was not necessary because it is already in the code.

 ----

 In the attached patch i also 'fixed' a windows issue where the tray menu
 wouldnt disappear: When you leave the tray menu fast with the mouse
 {{{
 docklet_menu_leave_enter
 }}}
 does not get a
 {{{
 event->type == GDK_LEAVE_NOTIFY && event->detail == GDK_NOTIFY_ANCESTOR
 }}}
  message. Instead it gets a
 {{{
 event->type == GDK_LEAVE_NOTIFY && event->detail == GDK_NOTIFY_UNKNOWN
 }}}
 message. So i added it. It works for me, but i dont know if it is a good
 idea to add it.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8352>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list