[Pidgin] #7404: trivial chat-invited signal handler causes crash
Pidgin
trac at pidgin.im
Sun Jan 4 19:57:50 EST 2009
#7404: trivial chat-invited signal handler causes crash
--------------------+-------------------------------------------------------
Reporter: jieryn | Owner: deryni
Type: defect | Status: new
Milestone: | Component: plugins
Version: 2.5.2 | Resolution:
Keywords: perl |
--------------------+-------------------------------------------------------
Comment(by zdeqb):
I'm trying to refresh my memory here, so I may be a bit off, but:
The reason for the crash, is that {{{args}}} on x86_64 is an array, not a
pointer, as on i386 (and other platforms), per [1].
va_copy could be used, but that's C99, and, if I remember correctly, C89
is aimed for.
Some automake/autoconf magic could also be used...
I put together a patch [2], which, using copy-and-paste bypassed the need
for passing a va_list around, but it's not exactly a ''fix'' (I last
looked at the patch a month ago, but I think it worked... if it doesn't, I
wouldn't be too surprised)
I'll take another look at this, when I have some time... but if someone
fixes it before me, I won't complain ;-)
[1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14557#c6
[2] http://welker.hu/~flaktack/purple-perl/purple-perl-uhmmm.patch
--
Ticket URL: <http://developer.pidgin.im/ticket/7404#comment:5>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list