[Pidgin] #8102: Authentication hangs if no request_ops handler is registered
Pidgin
trac at pidgin.im
Tue Jan 13 08:53:37 EST 2009
#8102: Authentication hangs if no request_ops handler is registered
---------------------------------------------------+------------------------
Reporter: Zeqfreed | Owner: deryni
Type: defect | Status: new
Component: XMPP | Version: 2.5.4
Keywords: cyrus sasl authentication request ops |
---------------------------------------------------+------------------------
If user of the library doesn't define ''request_action'' operation in
PurpleRequestUiOps, then authentication will hang inside
''jabber_auth_start_cyrus'' function (implemented in jabber/auth.c),
because the return value of ''purple_request_yes_no'' on line 330 isn't
checked.
It is silently assumed either of ''allow_cyrus_plaintext_auth'' or
''disallow_plaintext_auth'' will be called, which is not the case when
request_action operation not defined or handles the request incorrectly.
My suggestion is that at least a warning should be generated if described
condition occurs and the library shouldn't wait for user's response that
will never take place.
--
Ticket URL: <http://developer.pidgin.im/ticket/8102>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list