[Pidgin] #2606: Fix for #1384, (Sending "gone" notifications in IMs)

[Pidgin]

#2606: Fix for #1384, (Sending "gone" notifications in IMs)
-------------------------+--------------------------------------------------
 Reporter:  bobbybrasko  |        Owner:           
     Type:  patch        |       Status:  closed   
Milestone:  2.1.1        |    Component:  libpurple
  Version:  2.1.0        |   Resolution:  fixed    
 Keywords:               |  
-------------------------+--------------------------------------------------

Comment(by himdel):

 This patch is wrong and you might want to consider reverting it.

 Typing notification has *nothing* to do with closing conversation
 notification. Plus, closing window conversation is XMPP specific while the
 typing notification option can't be set per-account or even per-protocol.

 Also, this patch was meant to fix #1384, which it didn't, and #1384 is
 fixed properly now (via persistent conversations).

 Would there be interest for a patch that:
 a) reverts this
 b) adds a proper "send gone" option to:
  1. Preferences/Conversation
  2. (XMPP)Account/Advanced/XMPP Options
 ?
 If so, please specify the preference between b1 and b2 and I'll sent it
 right in.

 Because this thing really bugs me, sorry.
 (And bobby, please I mean no offense, I do understand it was a quick and
 easy way to make it possible not to send the gone notifications.)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2606#comment:3>
Pidgin <http://pidgin.im>
Pidgin