[Pidgin] #7621: MSN Protocol crashing since 16 months

[Pidgin]

#7621: MSN Protocol crashing since 16 months
---------------------+------------------------------------------------------
 Reporter:  Spaaken  |        Owner:  khc
     Type:  defect   |       Status:  new
Milestone:           |    Component:  MSN
  Version:  2.5.2    |   Resolution:     
 Keywords:  crash    |  
---------------------+------------------------------------------------------

Comment(by Spaaken):

 I can be more specific now - and the following applies to v2.5.4.

 I get a Segmentation Fault in thw following code:

 static gboolean
 msn_soap_write_cb_internal(gpointer data, gint fd, PurpleInputCondition
 cond, gboolean initial)

 at line
         written = purple_ssl_write(conn->ssl, conn->buf->str +
 conn->handled_len, conn->buf->len - conn->handled_len);

 because

 conn->ssl is NULL
 and also conn->buf is NULL

 I am not familiar with the code, so I don't know why both are NULL, but
 why are those conditions not catched? I inserted code to catch the
 conditions,
 but then it crashes at line 347 in soap.c, called by msn_soap_read_cb().

 The whole code seems to be non-functional in respect to side-conditions
 and side-effects. What I did was trying to cure symptoms, but the author
 should cure the causes. Whoever wrote this code should analyse the whole
 code and be aware of that pointers can always be NULL.

 I have also the impression that memory is not freed under error
 conditions.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7621#comment:2>
Pidgin <http://pidgin.im>
Pidgin