[Pidgin] #8199: join_chat doesn't validate its parameters and has no reasonable error message

[Pidgin]

#8199: join_chat doesn't validate its parameters and has no reasonable error
message
--------------------------+-------------------------------------------------
 Reporter:  mcepl         |     Owner:  lschiere
     Type:  defect        |    Status:  new     
Component:  unclassified  |   Version:  2.5.4   
 Keywords:                |  
--------------------------+-------------------------------------------------
 When I have this example piece of script:

 {{{
 my %components = (
         "room" => $room,
         "server" => $server,
         "handle" => $handle,
         "password" => ""
 );
 Purple::Serv::join_chat($conn,%components);
 }}}

 (note that I have whole hash as a parameter of join_chat, not just pointer
 to it, which is easy to do because documentation of %components is mostly
 non-existent)

 calling of join_chat ends with this (quite cryptic) error in --debug
 output:

 {{{
 (13:08:50) perl: Perl function exited abnormally: panic: realloc from
 wrong pool at (eval 3) line 176.
 (13:08:50) perl: ret_val = (nil)
 }}}

 and the function where the call is abrubptly ends.

 Correct all should be

 {{{
 Purple::Serv::join_chat($conn,\%components);
 }}}

 but importantly join_chat should handle errors in its parameters in more
 gentle manner.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8199>
Pidgin <http://pidgin.im>
Pidgin