[Pidgin] #8128: SIP/SIMPLE doesn't treat 'SIP:' case-insensitively

Pidgin trac at pidgin.im
Thu Jan 22 19:23:56 EST 2009


#8128: SIP/SIMPLE doesn't treat 'SIP:' case-insensitively
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  seanegan
     Type:  patch       |       Status:  new     
Milestone:  2.5.5       |    Component:  SIMPLE  
  Version:  2.5.4       |   Resolution:          
 Keywords:  SIP         |  
------------------------+---------------------------------------------------

Comment(by Marcus Sundberg):

 The SIMPLE plugin worked fine before the commit in
 "Revision: 8790ac55e1883120f6291456de62e845b73e0481"

 The attached patch simple reverts the confused strncmp->strcmp replacing.
 strncmp() is not used because strings lack NUL termination, but because
 we only want to compare the beginning of the string! For example the
 Content-Type header may be "text/html;charset=iso-8859-1" instead of
 just "text/html".

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8128#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list