[Pidgin] #3319: MSN group name display support
Pidgin
trac at pidgin.im
Sun Jul 5 15:12:41 EDT 2009
#3319: MSN group name display support
----------------------------+-----------------------------------------------
Reporter: manphiz | Owner: khc
Type: rejected_patch | Status: new
Milestone: | Component: MSN
Version: 2.2.0 | Resolution:
Keywords: msn group |
----------------------------+-----------------------------------------------
Comment(by VuDu):
Replying to [comment:66 deryni]:
> VuDu: Being willing to accept a patch that implements this the message
prefix way now and doing it correctly in the future is *exactly* what was
decided.
>
rekkanoryo used a bold+italic "if" before the "we want to support this
before 3.0.0" which doesn't *exactly* support your "*exactly* what was
decided" statement, therefore what I said before. Besides that, it seems
he didn't quite understood the issue, since it makes little sense to show
both buddy/group name and P4-Context... just look at the behavior of the
official MSN client.
>If you want the message prefix system added feel free to supply the patch
(especially as you seem to think it requires very little effort). I'm sure
it does in fact require relatively little effort but as I don't use MSN I
couldn't even test it if I wanted to, though I would gladly commit a patch
that appeared to have been written correctly and let other people test it.
>
Weren't enough patchs already suggested for this issue? Mass rejecting
patchs and then asking for another one shows lack of consideration for the
effort of the rejected patchs' users. If there's anything wrong one should
start where the others left before. I've used [http://pastebin.ca/1336515
this] based on the patchs submitted here and it worked just fine. I
understand Gaim started as a AOL client, but that was a decade ago and now
MSN has a huge weight on the IM world. Having AOL-only devs reviewing MSN-
only patchs might lead to problems like this.
> A new ticket requesting more useful support for the correct message
tagging feature would be acceptable as well, this ticket does not need to
stay open as it contains a large amount of discussion and argument
unrelated to the implementation of that feature.
>
I don't understand why somewhere in the middle of this ticket the word
"tag" started being used.
We always had (and should always have) "(timestamp) alias: message". The
only thing that changed is that now msn_message_get_attr(msg,
"P4-Context") might not be NULL, right? Why entangle things?
IMO, if it's there use it... if not, move on.
--
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:68>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list