[Pidgin] #3319: MSN group name display support

Pidgin trac at pidgin.im
Sun Jul 5 16:02:03 EDT 2009


#3319: MSN group name display support
----------------------------+-----------------------------------------------
 Reporter:  manphiz         |        Owner:  khc
     Type:  rejected_patch  |       Status:  new
Milestone:                  |    Component:  MSN
  Version:  2.2.0           |   Resolution:     
 Keywords:  msn group       |  
----------------------------+-----------------------------------------------

Comment(by VuDu):

 Replying to [comment:69 felipec]:
 > P4-Context is meant to be a per-message nick; whatever Pidgin devs have
 decided to do with it is wrong.

 [http://www.hypothetic.org/docs/msn/research/msnc1.php So] it seems...
 {{{
 If the official client receives the following:

 MIME-Version: 1.0\r\n
 Content-Type: text/plain\r\n
 P4-Context: My friendlyname\r\n
 \r\n
 Hello

 It would display:

 My friendlyname says:

 Hello
 }}}

 Documented
 [http://www.hypothetic.org/docs/msn/phorum/read.php?f=1&i=6677&t=6677
 here] for the first time, five years ago.

 Replying to [comment:56 deryni]:
 > The msn-pecan patch is not "good" but it does "work". The choices as I
 see them currently are:
 >  1. Do nothing, leaves things as broken as they are now rendering these
 group chats unusable.
 >  1. 'Tag' each message with the P4-Context header as a prefix (so
 <timestamp> GroupName: P4Name: message) or some other similar tagging
 method.
 >  1. Use a patch like the one Felipe has in msn-pecan which sets the user
 settable alias for the buddy to the value of the P4-Context header for the
 duration of the message and then sets it back to whatever value it had
 previously afterwards.
 >  1. Determine what would be involved to allow libpurple to support
 additional tags of this sort (and potentially other sorts) for incoming
 (and outgoing?) messages.
 >
 > These options are listed in roughly the order they are easy to implement
 (I have placed the tag option about the alias patch option despite a patch
 for the latter existing because I think the tagging is less of an ugly
 hack).
 >
 > I think the first is a non-option at this point, I think the last is
 potentially useful but requires a longer timespan than is likely helpful,
 and between the middle two I like the tagging better than aliasing because
 it seems like less of a hack to me (as it doesn't potentially trigger tab
 title changes, window title changes, buddy list refreshing, etc.).
 >
 > A decision needs to be made on this point and some code committed, I
 have given my preference but am not going to make the decision as I don't
 use MSN in any real way.

 Alright, so the "non-option" turned out to be the choice made.
 IMO, put 3 in action and start planning 4 and that requires picking up the
 patches suggested before. What do you think?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:70>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list