[Pidgin] #3319: MSN group name display support

[Pidgin]

#3319: MSN group name display support
----------------------------+-----------------------------------------------
 Reporter:  manphiz         |        Owner:  khc
     Type:  rejected_patch  |       Status:  new
Milestone:                  |    Component:  MSN
  Version:  2.2.0           |   Resolution:     
 Keywords:  msn group       |  
----------------------------+-----------------------------------------------

Comment(by felipec):

 Replying to [comment:73 QuLogic]:
 > Replying to [comment:69 felipec]:
 > > Correct, and it's a really really minor change:
 > > http://github.com/felipec/msn-
 pecan/commit/1386c1f81fb3214d67f1de9b3349b85bbd79adc9
 > >
 >
 > OK, fine, I tried your patch.

 See the author field; it is not my patch.

 > It doesn't work.

 How so?

 >  * Send message with P4-Context. Displayed name in conversation line
 changes. Good.

 Ah, so it *does* work.

 >  * Send message without P4-Context. Display name is still the same as
 with P4-Context. Wrong.

 If that indeed happens the patch still works, although it has some bugs.

 However, I fail to see how it might fail. What is
 msn_message_get_attr(msg, "P4-Context") returning?

 Looking at msn-pecan's purple_buddy_set_public_alias I'm starting to
 wonder; which buddy is the conversation picking to show the message?

 > Additionally, calling `purple_blist_alias_buddy` emits a `blist-node-
 aliased` signal. Given that any plugin can listen to said signal, who
 knows what the ramifications could be, especially if one of those
 chatrooms was very busy.

 Right, I should probably copy purple_blist_server_alias_buddy and remove
 the signal (and probably other unnecessary stuff too). But seriously, who
 is listening to such a signal?

 I'll better wait until I get a bug report for that, but so far, nobody has
 complained.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:74>
Pidgin <http://pidgin.im>
Pidgin