[Pidgin] #9626: away message is unset during login to AIM

Pidgin trac at pidgin.im
Mon Jul 6 01:04:05 EDT 2009


#9626: away message is unset during login to AIM
------------------------------------+---------------------------------------
 Reporter:  tmm1                    |        Owner:  MarkDoliner
     Type:  patch                   |       Status:  new        
Milestone:  Patches Needing Review  |    Component:  AIM        
  Version:  2.5.8                   |   Resolution:             
 Keywords:                          |  
------------------------------------+---------------------------------------

Comment(by tmm1):

 That should be equivalent, but you probably want:
 {{{
 --- libpurple/protocols/oscar/oscar.c
 e11e875546106d01efbd959e5d1d89b8398c11db
 +++ libpurple/protocols/oscar/oscar.c
 8a94b09e8aeb48438395274cbd2d4c01911fa9ed
 @@ -3977,7 +3977,8 @@ static int purple_bosrights(OscarData *o
                 message = NULL;
         tmp = purple_markup_strip_html(message);
         itmsurl = purple_status_get_attr_string(status, "itmsurl");
 -       aim_srv_setextrainfo(od, FALSE, 0, TRUE, tmp, itmsurl);
 +
 +       aim_srv_setextrainfo(od, FALSE, 0, (message || itmsurl) ? TRUE :
 FALSE, tmp, itmsurl);
         g_free(tmp);

         presence = purple_status_get_presence(status);
 }}

 I guess the question is if aim_srv_setextrainfo() is ever used to
 explicitly set a null message/itmsurl. If so, this patch would be
 preferable, otherwise mine makes more sense.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9626#comment:4>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list