[Pidgin] #9703: add a GHashTable cache for conversations to speed up find_conversation_with_account

[Pidgin]

#9703: add a GHashTable cache for conversations to speed up
find_conversation_with_account
------------------------------------+---------------------------------------
 Reporter:  tmm1                    |        Owner:  darkrain42
     Type:  patch                   |       Status:  new       
Milestone:  Patches Needing Review  |    Component:  libpurple 
  Version:  2.5.8                   |   Resolution:            
 Keywords:                          |  
------------------------------------+---------------------------------------
Changes (by darkrain42):

  * owner:  => darkrain42
  * milestone:  => Patches Needing Review


Comment:

 A weird quirk exists in `purple_conversation_new` where it will create a
 new ''chat'' for the same (account, name) pair if the user hasn't left
 that room already. That needs to be resolved in order to use this hash
 table.

 From #pidgin, nosnilmot contributed:
 {{{
 10:51:00 < nosnilmot> darkrain42: (replying to some comment you made
 yesterday
                       about purple_conversation_new) a0cc5861 included
 cleanup
                       to purple_conversation_new, which was reverted in
                       65f3bcd3, there's certainly a reason for the odd
 behavior
                       but I can't remember exactly what it is - possibly
                       related to MSN's unnamed chats
 10:52:54 < deryni> nosnilmot: Yeah, I saw the back and forth commits for
 it but
                    they didn't provide enough context by themselves for me
 to
                    figure it out.
 10:53:34 < nosnilmot> deryni: I vaguely remember some discussion about it
 at
                       the time, but can't remember where the discussion
 took
                       place :(
 10:55:45 < deryni> I actually wondered whether that odd behaviour was the
 cause
                    of some of the yahoo and MSN multiple chat window
 problems
                    we've had reported.
 10:56:27 < deryni> But yeah, it would make sense for that to have been a
                    workaround for MSN unnamed chats if we always use the
 same
                    name for them.
 10:56:44 < deryni> In which case I'd argue we should make the prpl stop
 doing
                    that and remove the workaround.
 11:04:04 < nosnilmot> deryni / darkrain42:
 http://pidgin.im/pipermail/devel/2008-January/004653.html
 11:05:48 < deryni> nosnilmot: That looks like if we made MSN give chats
 unique
                    names we'd be ok without the odd code, right?
 11:06:21 < nosnilmot> deryni: probably, but it would look uglier
 11:06:29 < nosnilmot> not the code, the UI. code would be cleaner :)
 11:06:49 < deryni> Could we use conversation titles to avoid that?
 11:10:17 < nosnilmot> conversation titles? aren't they the same as the
 chat
                       name? I have been under a rock for too long
 11:10:36 < deryni> I was sort of hoping you'd know what they were, since I
                    don't offhand. =)
 }}}

 The revisions referenced are a0cc58611eba803e55891cb8cfefa80d29a8413b and
 65f3bcd3e7dfafc090e0cdfa3e7fff40d82e3c9c and link is
 http://pidgin.im/pipermail/devel/2008-January/004653.html

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9703#comment:1>
Pidgin <http://pidgin.im>
Pidgin