[Pidgin] #8799: Small adjustment to previous fix in Message Notification Plugin

Pidgin trac at pidgin.im
Mon Jun 1 18:13:50 EDT 2009


#8799: Small adjustment to previous fix in Message Notification Plugin
-------------------------+--------------------------------------------------
 Reporter:  Luigiwalser  |        Owner:  deryni      
     Type:  defect       |       Status:  pending     
Milestone:               |    Component:  pidgin (gtk)
  Version:  2.5.5        |   Resolution:              
 Keywords:               |  
-------------------------+--------------------------------------------------
Changes (by deryni):

  * status:  new => pending


Comment:

 Sorry for taking so long to get back to this, if you switch the order of
 those two blocks in the current plugin do you stop getting your
 undesirable behaviour? Assuming you are still seeing that behaviour.

 It seems more likely to me that the issue is that your patch used
 gdk_window_show directly and that the accepted patch uses (eventually)
 gtk_window_present. gtk_window_present will call gdk_window_show but will
 also call gdk_window_focus (which, for window management environments that
 support the EWMH will request that the window be made active and for those
 that don't will call XRaiseWindow).

 "Raise but not take focus" when the window is unminimized is what the
 'Raise' option does, purely unminimize is not currently an option, "do
 what is needed to get attention" is what the 'Present' option does
 currently.

 I'm hesitant to add yet another option for 'Unminimize' but I'm not sure
 how else to actually solve this issue, given that I'm reasonably sure some
 people are going to be unhappy no matter which way 'Present' actually
 works (focusing or not focusing the window).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8799#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list