[Pidgin] #9286: Saved Statuses - "Modify..." button bug

[Pidgin]

#9286: Saved Statuses - "Modify..." button bug
------------------------------------+---------------------------------------
 Reporter:  andrei_natanael         |        Owner:              
     Type:  patch                   |       Status:  pending     
Milestone:  Patches Needing Review  |    Component:  pidgin (gtk)
  Version:                          |   Resolution:              
 Keywords:  modify saved statuses   |  
------------------------------------+---------------------------------------
Changes (by deryni):

  * status:  new => pending


Comment:

 I agree that isn't logical, however what I said is that I do not see that
 happening here. My Modify... button is correctly disabled in that case.
 What version of pidgin are you using?

 And no, disabling the Modify... button when multiple statuses is selected
 has no bearing on being able to have multiple modify windows open for the
 same status.

 Select two statuses, hit Modify..., get two modify status windows, go back
 to the Saved Statuses dialog, hit Modify... again, get the same two pre-
 existing dialogs refocused, close the Saved Statuses dialog, re-open Saved
 Statuses dialog, select a single status for which a window already exists,
 hit Modify..., get a duplicate window for that status. See? Multiple
 selection and duplicate windows are unrelated issues.

 So I stand by thinking we need to disallow modification of the active
 status but do not need (or want) the multi-selection change.

 The reason we get multiple windows for a given status when the Saved
 Statuses dialog has been closed in the middle is because we store the ID
 of the window in the Saved Statuses dialog tree store, so once the dialog
 is closed we 'forget' we had the window open. There are a number of ways
 this could potentially be solved, and a patch implementing a good one
 would likely be accepted.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9286#comment:3>
Pidgin <http://pidgin.im>
Pidgin