[Pidgin] #9308: wrong datatype in libpurple perl bindings imgStore.xs

[Pidgin]

#9308: wrong datatype in libpurple perl bindings imgStore.xs
--------------------------------------------+-------------------------------
 Reporter:  quick                           |        Owner:           
     Type:  patch                           |       Status:  new      
Milestone:                                  |    Component:  libpurple
  Version:  2.5.5                           |   Resolution:           
 Keywords:  perl imgStore datatype typemap  |  
--------------------------------------------+-------------------------------

Comment(by darkrain42):

 Requiring plugins to pass in the legnth of the data isn't very "perl-
 like", I think.

 This is my take on it, although I'm still pretty sure that
 purple_imgstore_get_data is broken (it needs to use the length of the data
 to build the perl string).

 {{{
 --- libpurple/plugins/perl/common/ImgStore.xs
 99bfe463e223624b1e809f12a99ccf7294e75e5f
 +++ libpurple/plugins/perl/common/ImgStore.xs
 c24c80443053d38f553f6916a52b1158a5395a38
 @@ -4,22 +4,16 @@ Purple::StoredImage
  PROTOTYPES: ENABLE

  Purple::StoredImage
 -purple_imgstore_add(data, size, filename)
 -       void *data
 -       size_t size
 -       const char *filename
 +purple_imgstore_add(char *data, size_t length(data), const char
 *filename)

  int
 -purple_imgstore_add_with_id(data, size, filename)
 -       void *data
 -       size_t size
 -       const char *filename
 +purple_imgstore_add_with_id(char *data, size_t length(data), const char
 *filename)

  Purple::StoredImage
  purple_imgstore_find_by_id(id)
         int id

 -gconstpointer
 +const char*
  purple_imgstore_get_data(i)
         Purple::StoredImage i

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9308#comment:6>
Pidgin <http://pidgin.im>
Pidgin