[Pidgin] #4598: Plus! color tags

[Pidgin]

#4598: Plus! color tags
-----------------------------------------+----------------------------------
 Reporter:  daniele_athome               |        Owner:              
     Type:  patch                        |       Status:  new         
Milestone:  Patches Needing Improvement  |    Component:  pidgin (gtk)
  Version:  2.3.1                        |   Resolution:              
 Keywords:  pidgin blist markup          |  
-----------------------------------------+----------------------------------

Comment(by daniele_athome):

 Replying to [comment:15 elb]:
 > This patch looks like a memory leak waiting to happen -- it strdup()s a
 string returned from a signal and discards the signal result.  I would
 generally expect the signal handler in a situation like this to have
 allocated the string it wished to return.

 Already fixed, I'll post the upgraded patch tomorrow morning.

 Replying to [comment:15 elb]:
 > It's also not clear to me why this signal is named "drawing-buddy" and
 takes a buddy as an argument, but seems to be utilized only to return
 markup for the buddy's username.  A more specific signal name which
 indicates this rather limited scope would be appropriate here.

 The name is absolutely not self-explaining, you can change with anything
 you want :)
 The handler should a have a buddy because of the information it can
 retrieve; passing only the buddy alias string could not be enough; for
 example, the plugin should colorize the buddy only if the user hasn't
 defined a custom alias.

 Replying to [comment:15 elb]:
 > It looks to me like the whole purpose of this plugin is to handle MSN's
 ill-conceived username markup language; this is something which should
 properly be handled by the MSN protocol plugin.  Perhaps a signal should
 be emitted from the MSN protocol plugin to the effect of msn-buddy-parse-
 markup, with a default implementation of simply stripping these codes from
 the nickname.

 In windows, Plus! nicks are managed by a windows live messenger patch
 (that is messenger plus!), and it is not a protocol extension; all is
 based on having that patch installed; that patch will render colored nicks
 correcly.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:30>
Pidgin <http://pidgin.im>
Pidgin