[Pidgin] #9371: Avatars support in Gadu-Gadu protocol.

[Pidgin]

#9371: Avatars support in Gadu-Gadu protocol.
------------------------------------------+---------------------------------
 Reporter:  kkszysiu                      |        Owner:  darkrain42
     Type:  patch                         |       Status:  new       
Milestone:  Patches Needing Improvement   |    Component:  Gadu-Gadu 
  Version:  2.5.6                         |   Resolution:            
 Keywords:  avatars, gg, gadu, gadu-gadu  |  
------------------------------------------+---------------------------------
Changes (by darkrain42):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 This patch needs the following changes:
   * Braces for the `if (buddy == NULL)` check. The `return;` at line 100
 always executes.
   * Use '%u' for printing the UIN and don't cast it to an unsigned long.
   * Do not do `strchr(url_text, '\n') + 1`. Store the result of strchr()
 someplace, check that it's not null, and then assign it to a new variable.
 That would crash if there was no newline in the response from the server.
   * Check the return value of xmlnode_from_str
   * Do not walk the xmlnode structure via dereferencing the child data
 member. Use multiple xmlnode_get_child() calls and check the return
 values.
   * Do not print out strings that might be null (this unfortunately
 crashes on Win32). Change it to something like `uin ? uin : "(null)`
 instead.
   * Make sure that is_blank is not NULL before calling strcmp (or use
 purple_strequal, which will be in Pidgin 2.6.0)
   * Shouldn't
 [http://developer.pidgin.im/attachment/ticket/9371/gg%2Cc.diff4#L72 line
 72] be '&&' instead of '||'? How can you set the buddy icon when you don't
 know what user it's for?
   * If is_blank is set to '1', should we be calling
 purple_buddy_icons_set_for_user(account, buddy, NULL, 0, NULL)? (or what
 does that mean if not "this buddy has no icon set"?)
   * Re-arrange these functions so that you don't need to declare
 prototypes (put them right above ggp_generic_status_handler, for example).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9371#comment:5>
Pidgin <http://pidgin.im>
Pidgin