[Pidgin] #9371: Avatars support in Gadu-Gadu protocol.

Pidgin trac at pidgin.im
Mon Jun 22 16:26:19 EDT 2009


#9371: Avatars support in Gadu-Gadu protocol.
------------------------------------------+---------------------------------
 Reporter:  kkszysiu                      |        Owner:  darkrain42
     Type:  patch                         |       Status:  new       
Milestone:  Patches Needing Improvement   |    Component:  Gadu-Gadu 
  Version:  2.5.6                         |   Resolution:            
 Keywords:  avatars, gg, gadu, gadu-gadu  |  
------------------------------------------+---------------------------------

Comment(by darkrain42):

 Two comments:
   * Please name the xmlnode* variables more consistently. If the xmlnode
 represents <avatars>, name it '''xmlnode_avatars''' or '''avatars''', not
 '''xmlnode_user'''.
   * Will this re-retrieve an avatar every time we receive a new presence
 update from a buddy? How do other clients determine if the buddy's avatar
 has changed? At the very least, we should store either the timestamp or
 URL and not re-download the full image if it's the same as what is
 currently in use.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9371#comment:8>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list