[Pidgin] #9463: Gadu Gadu prpl - contacts list synchronisation with server

[Pidgin]

#9463: Gadu Gadu prpl - contacts list synchronisation with server
----------------------------------------------------+-----------------------
 Reporter:  kkszysiu                                |        Owner:  bartosz  
     Type:  patch                                   |       Status:  new      
Milestone:  Patches Needing Improvement             |    Component:  Gadu-Gadu
  Version:  2.5.7                                   |   Resolution:           
 Keywords:  gadu, gg server, sync, synchronisation  |  
----------------------------------------------------+-----------------------
Changes (by resiak):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 is_successful = (gint *) gg_userlist_request(info->session,
 GG_USERLIST_GET, NULL);

 This is wrong: why are you casting an int to a pointer to an int?

         if(is_successful == 0) {
                 purple_notify_info(gc, NULL,
                         _("Buddy list downloaded"),
                         _("Your buddy list was downloaded from the
 server."));
         }

 This isn't true: the GET request has been sent to the server, but a reply
 hasn't arrived yet.

 Why is a notification needed for PUT or SET at all? I'd be really annoyed
 if a dialog box popped up every time I signed in or added/removed a
 contact.

 I think {{{gg_userlist_request(info->session, GG_USERLIST_PUT, NULL);}}}
 actually deletes the buddy list from the server (based on that being what
 ggp_action_buddylist_delete calls). I think you should be calling the
 current body of ggp_action_buddylist_put() when you want to save the buddy
 list to the server.

 And, having made the buddy list automatically sync itself, you should
 remove the corresponding prpl actions.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9463#comment:2>
Pidgin <http://pidgin.im>
Pidgin